Create accountLogin

Recent searches

No recent searches

Search options

Only available when logged in.
hachyderm.io is one of the many independent Mastodon servers you can use to participate in the fediverse.
Hachyderm is a safe space, LGBTQIA+ and BLM, primarily comprised of tech industry professionals world wide. Note that many non-user account types have restrictions - please see our About page.

Administered by:

Server stats:

8.9K
active users

hachyderm.io: AboutStatusProfiles directoryPrivacy policy

Mastodon: AboutGet the appKeyboard shortcutsView source codev4.3.8

Public
Cassandrich

Replace if(0) in printf with gotos?

(Poll is non binding, just for fun)

· 55 people · Closed
Cassandrich

Proposed patch to replace if(0) obfuscation with explicit gotos. 🤔

Looks sufficiently non-invasive and like a significant improvement to readability.

Patch text: diff --git a/src/stdio/vfprintf.c b/src/stdio/vfprintf.c index 360d723a..3c450c3a 100644 --- a/src/stdio/vfprintf.c +++ b/src/stdio/vfprintf.c @@ -557,11 +557,11 @@ static int printf_core(FILE *f, const char *fmt, va_list *ap, union arg *nl_arg, case 'x': case 'X': a = fmt_x(arg.i, z, t&32); if (arg.i && (fl & ALT_FORM)) prefix+=(t>>4), pl=2; - if (0) { + goto ifmt_tail; case 'o': a = fmt_o(arg.i, z); if ((fl&ALT_FORM) && p<z-a+1) p=z-a+1; - } if (0) { + goto ifmt_tail; case 'd': case 'i': pl=1; if (arg.i>INTMAX_MAX) { @@ -573,7 +573,7 @@ static int printf_core(FILE *f, const char *fmt, va_list *ap, union arg *nl_arg, } else pl=0; case 'u': a = fmt_u(arg.i, z); - } + ifmt_tail: if (xp && p<0) goto overflow; if (xp) fl &= ~ZERO_PAD; if (!arg.i && !p) {
Aug 18, 2024, 05:22 PM·Public·Web
0boosts·7favorites
Public
Enno T. Boland

@dalias I never thought I would've said that, but please use gotos! :D

Public
Enno T. Boland

@dalias It's a misconception that `goto`s must not be used. There are usecases - especially in C which lacks the 'defer' statement - where it's just needed to write non-awful code.

Public
Cassandrich

@Gottox switch statements are gotos anyway. 🙃

Quiet public
Rob Landley

@dalias neither is readable, why are you hardwiring out chunks of the code that are still there?

Quiet public
Cassandrich

@landley I'm not. But the if(0) led folks to misread it the way you just did, which is why I'm trying to rectify that.

ExploreLive feeds
About